Merge pull request #1116 from aarroyoc/fix-open-lis

Allow all kinds of string to be processed in open/4

src/lib/builtins.pl

@@ -1477,7 +1477,11 @@ open(SourceSink, Mode, Stream, StreamOptions) :-
        (   SourceSink = stream(S0) ->
            '$set_stream_options'(S0, Alias, EOFAction, Reposition, Type),
            Stream = S0
-       ;   '$open'(SourceSink, Mode, Stream, Alias, EOFAction, Reposition, Type)
+       ;   (
+                atom(SourceSink) ->
+                atom_chars(SourceSink, SourceSinkString)
+           ;    SourceSink = SourceSinkString
+           ), '$open'(SourceSinkString, Mode, Stream, Alias, EOFAction, Reposition, Type)
        )
     ).
 

src/loader.pl

@@ -506,7 +506,7 @@ open_file(Path, Stream) :-
     (  atom_concat(_, '.pl', Path) ->
        open(Path, read, Stream)
     ;  catch(open(Path, read, Stream),
-             error(existence_error(source_sink, Path), _),
+             error(existence_error(source_sink, _), _),
              ( atom_concat(Path, '.pl', ExtendedPath),
                open(ExtendedPath, read, Stream) )
             )

src/machine/system_calls.rs

@@ -3169,31 +3169,10 @@ impl MachineState {
 
                 let options = self.to_stream_options(alias, eof_action, reposition, stream_type);
 
-                let mut stream = match self.store(self.deref(self[temp_v!(1)])) {
+                let mut iter = self.heap_pstr_iter(self[temp_v!(1)]);
-                    Addr::Con(h) if self.heap.atom_at(h) => match &self.heap[h] {
+                let file_spec = clause_name!(iter.to_string(), self.atom_tbl);
-                        &HeapCellValue::Atom(ref atom, _) => {
-                            self.stream_from_file_spec(atom.clone(), indices, &options)?
-                        }
-                        _ => {
-                            unreachable!()
-                        }
-                    },
-                    Addr::Char(c) => {
-                        let atom = clause_name!(c.to_string(), self.atom_tbl);
-                        self.stream_from_file_spec(atom, indices, &options)?
-                    }
-                    Addr::PStrLocation(h, n) => match &self.heap[h] {
-                        &HeapCellValue::PartialString(_, _has_tail @ false) => {
-                            let mut heap_pstr_iter = self.heap_pstr_iter(Addr::PStrLocation(h, n));
 
-                            let file_spec = clause_name!(heap_pstr_iter.to_string(), self.atom_tbl);
+                let mut stream = self.stream_from_file_spec(file_spec, indices, &options)?;
-
-                            self.stream_from_file_spec(file_spec, indices, &options)?
-                        }
-                        _ => self.stream_from_file_spec(clause_name!(""), indices, &options)?,
-                    },
-                    _ => self.stream_from_file_spec(clause_name!(""), indices, &options)?,
-                };
 
                 *stream.options_mut() = options;