make retract_local_clauses safe, remove warning about overwriting warning in do_not_duplicate_path_components test

src/machine/load_state.rs

@@ -344,7 +344,7 @@ impl<'a> LoadState<'a> {
         key: PredicateKey,
         clause_locs: &SliceDeque<usize>,
     ) {
-        let (clause_target_poses, is_dynamic) = self
+        let result_opt = self
             .wam
             .indices
             .get_predicate_skeleton(&compilation_target, &key)
@@ -358,14 +358,16 @@ impl<'a> LoadState<'a> {
                     })
                     .collect(),
                  skeleton.is_dynamic)
-            }).unwrap();
+            });
 
-        self.retract_local_clauses_by_locs(
+        if let Some((clause_target_poses, is_dynamic)) = result_opt {
-            compilation_target,
+            self.retract_local_clauses_by_locs(
-            key,
+                compilation_target,
-            clause_target_poses,
+                key,
-            is_dynamic,
+                clause_target_poses,
-        );
+                is_dynamic,
+            );
+        }
     }
 
     pub(super) fn retract_local_clauses_by_locs(

tests/scryer/issues.rs

@@ -29,7 +29,6 @@ fn do_not_duplicate_path_components() {
         "\
         caught: e\n\
         false.\n\
-        Warning: overwriting $initialization_goals/1\n\
         caught: e\n\
         false.\n\
         ",